search

crow-translate / QOnlineTranslator

A library for Qt5 that provides free usage of Google, Yandex and Bing translate API.
GNU General Public License v3.0
80 stars 13 forks source link

Add -cppcoreguidelines-avoid-do-while #61

Closed tim77 closed 1 year ago

tim77 commented 1 year ago

https://github.com/crow-translate/crow-translate/pull/616#issuecomment-1762852627

Shatur commented 1 year ago

Thanks! Conventional commits are nice, probably worth considering switching in the future. But until now I renamed the PR.

While you are at it, could you take a look at #60? An easy change.

tim77 commented 1 year ago

Conventional commits are nice, probably worth considering switching in the future. But until now I renamed the PR.

I was in a hurry again, sorry. Should I also rename the commit to Add -cppcoreguidelines-avoid-do-while?

While you are at it, could you take a look at https://github.com/crow-translate/QOnlineTranslator/issues/60? An easy change.

:soon:

Shatur commented 1 year ago

I was in a hurry again, sorry. Should I also rename the commit to Add -cppcoreguidelines-avoid-do-while?

No need, I renamed it on auto squash merge. I like conventional commit names, but this project currently don't use it, so I renamed it for consistency.