crowbartools / Firebot

A powerful all-in-one bot for Twitch streamers
https://firebot.app
GNU General Public License v3.0
356 stars 101 forks source link

3.1.1 Logging in with MS Account - Blank Screen #155

Closed wcphart closed 7 years ago

wcphart commented 7 years ago

When logging in with a MS account during setup after upgrading to 3.1.1, when you click on the blue bar "Login with your Microsoft Account" the popup that is opened is a blank white page.

How do I log back in now that I have updated to 3.1.1?

itsjesski commented 7 years ago

For now I'd recommend downgrading until we can take a look at the bug.

wcphart commented 7 years ago

@Firebottle I was able to log in without the MS account. Apparently you can set a password in Mixers account area, and login with that password OR use MS login. So for now, I can login but would prefer to use MS login eventually.

itsjesski commented 7 years ago

Ah okay! I'm sure that eventually the mixer login will go away completely and will 100% use the microsoft login.

kateract commented 7 years ago

I have a question in to the electron-oauth2 guy about this. The windows display properly if I turn on sandboxing, but the window itself doesn't close and return the tokens. So, most likely a security issue of some sort with Chromium.

itsjesski commented 7 years ago

I know I had this working in the interactive v1 branch for old Firebot. Deeky helped fix the issue. It wasn't using oauth2 but it worked the exact same way.

EDIT: @kateract here is the fix for this from the other branch. Don't know if this helps or not. https://github.com/Firebottle/Firebot/commit/717ba89e862279973de7347dbb9d5f70c414ce56

itsjesski commented 7 years ago

Release 4.0.0-beta.1