crowbartools / Firebot

A powerful all-in-one bot for Twitch streamers
https://firebot.app
GNU General Public License v3.0
354 stars 100 forks source link

[Bug] Custom Viewer Roles do not update when usernames are changed on Twitch #2203

Closed huds601 closed 7 months ago

huds601 commented 1 year ago

Is there an existing issue for this?

Current Behavior

I use Viewer Roles to keep track of a one-time redemption for sticker giveaways. When the user redeems the channel point reward, it adds the role to them to that, if they try to redeem again, it will reject the redemption and refund the points.

I noticed that one of my viewers was able to redeem a second time, and they had recently changed their Twitch username.

Their old name was cowboyknuckles, their new name is CBK_x.

However, in the Custom Role, they are still showing as cowboyknuckles, but only appear as CBK_x in my viewers database. While one of the 2 roles I use is applied the one they redeemed before changing their name is no longer applied to their account.

Profile Custom Role

Expected Behavior

Custom roles should follow users post-name change

Steps To Reproduce

  1. Add a Twitch user to a custom role
  2. Change the username of the Twitch user

Version

5.57.0

What operating system are you using Firebot on?

Windows 10

Relevant log output

No response

Contact Details (Optional)

Discord: huds601

CKY- commented 1 year ago

part of #2198

JoeruCodes commented 1 year ago

one possible fix for this could be the use of userID tracking rather than username tracking which means that instead of assigning the roles to the usernames (which can be changed) we can assign the same to the userID (which cannot be changed even after changing the username)

itsjesski commented 10 months ago

Tagging as v6 based on the info in #2198

zunderscore commented 7 months ago

Released in v5.62.0