crowbartools / Firebot

A powerful all-in-one bot for Twitch streamers
https://firebot.app
GNU General Public License v3.0
356 stars 101 forks source link

Option to put user back in the last group they were in on reconnect #499

Closed EarWaxCandy closed 6 years ago

EarWaxCandy commented 6 years ago

If you're reporting an issue, please fill out & do the following questions. If you leave them blank the issue may be closed due to lack of information.

What version of Firebot are you running?

Release v4.9.0

Please describe the issue or feature requests in as much detail as possible.

I'm not sure that this is supposed to be this way. A user presses a button, the button does a change group command. They don't show up in the viewer groups, however the board does change scenes. if the user refreshes the stream, they end up back into the default group on the main scene. shouldn't changing group actually assign them to that group permanently?

Contact Us!

Did you know that we have a help channel in discord as well? https://discord.gg/DegW792

itsjesski commented 6 years ago

Yes, that is intended behavior. We rely on Mixer to keep track of which groups people are in instead of keeping track of all of that in the bot itself. When a user refreshes Mixer they are treated as a new user for all intents and purposes. So they're thrown back into their original group.

Are you running into times when this is a big issue? Could you give us more detail on the situation?

EarWaxCandy commented 6 years ago

I'm planning to make a sort of "choose your own adventure game" using multiple scenes etc. At the end, I'm giving away game codes, gift cards, etc. if for some reason the board were to disconnect, crash, or whatever, people would lose their progress I can't risk that. I know that you can manually assign a user to a viewer group. Not sure if they stay that way permanently? If so, is it possible to put someone in a group via script or is it something that can be added as an option.

On Jan 30, 2018 8:49 PM, "Firebottle" notifications@github.com wrote:

Yes, that is intended behavior. We rely on Mixer to keep track of which groups people are in instead of keeping track of all of that in the bot itself. When a user refreshes Mixer they are treated as a new user for all intents and purposes. So they're thrown back into their original group.

Are you running into times when this is a big issue? Could you give us more detail on the situation?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Firebottle/Firebot/issues/499#issuecomment-361796845, or mute the thread https://github.com/notifications/unsubscribe-auth/AboYy91YBldLz3OrqYIcmHs6nRXBeaeCks5tP8a7gaJpZM4RzR2E .

ebiggz commented 6 years ago

It's certainly possible to add a toggle on the Change Group effect to make the user "permanently change groups", aka update the group data file. @Firebottle Would there be any adverse implications to adding something like that? If not, we can mark this as a feature request. The choose your own adventure idea sounds really cool.

itsjesski commented 6 years ago

Only problem is that the groups json file wasn't really built for that or meant to hold that many people. With what we have right now those names never get cleared, so after a few streams that json file is going to be massive.

I think we could probably do this once we get the new DB in place that will track points and stuff. We could just add another column there for "last group" or something.