search

crowbartools / MixrElixr

Browser extension that enhances your Mixer viewing experience with custom emotes, new features, and a ton of options.
https://mixrelixr.com
GNU General Public License v3.0
23 stars 7 forks source link

[Bug] Not showing streams without a game set #33

Closed MAPReiff closed 6 years ago

MAPReiff commented 6 years ago

When only 1 streamer I'm following is live, it will have a badge on the plugin with 1, but not show it in the plugin's popup.

saejkl
ThePerry-2015 commented 6 years ago

That's weird, on my end it works just fine. unknown Which version of MixrElixr are you using? Should be able to see the version # on chrome://extensions

MAPReiff commented 6 years ago

Plugin version 1.2, chrome version 62.0.3202.89 on MacOS.

ThePerry-2015 commented 6 years ago

I just reinstalled my extension from the Webstore as I was using the source code directly in Chrome to see if that made any change, but it still shows me the one stream that I'm following just fine. Might have to wait and see if there are anyone else with the same issue as I can't see why it should be showing up differently for you, even if you are on Mac OS. I was on an older Chrome for some reason, but I upgraded to the same version as you and it still shows up like it should.

Plugin: 1.2 Chrome: Version 62.0.3202.89 (Official Build) (64-bit) Windows 10 Pro Insider Preview Build: 17025_rs_prerelease.171020-1626

MAPReiff commented 6 years ago

I highly doubt it, but perhaps its the MacOS version of chrome which has the issue. I'll try it on my Windows rig when I get back home and see what happens.

ebiggz commented 6 years ago

I have a feeling this is probably related to a bug we know about (but haven’t made a issue for, I need to do that still) where any streamer that doesn’t have a game set won’t show up in the list. It’s possible that the one streamer online didn’t have a game set and thus, wasn’t showing up.

ThePerry-2015 commented 6 years ago

You are completely right @ebiggz, I didn't think of that one when I saw this one. But if you check the screenshot in the first post you see that it's Monstercat and they don't have a game set as you only see their title. So that is the issue here.

ebiggz commented 6 years ago

I totally missed the screenshot. Yup, that’s got to be it.

MAPReiff commented 6 years ago

If its an issue with no game being set, is it that it's looking for a game string from the api to place on the stream preview in the plugin, not finding one, and thus not posting the stream? I'm not sure if this would apply to how you guys do it, but why not just have something like if(game = null){var game = "No Game"} to make sure game-less are given a string and thus work.

itsjesski commented 6 years ago

Yeah, thats exactly what needs to happen. You can blame me for that one. Didn't even think about streams not having titles or games set. We can get it fixed soon.

ebiggz commented 6 years ago

@MAPReiff Yup we know how to get it to work, it was just an oversight. It'll be in the next release :)