search

crowbartools / MixrElixr

Browser extension that enhances your Mixer viewing experience with custom emotes, new features, and a ton of options.
https://mixrelixr.com
GNU General Public License v3.0
23 stars 7 forks source link

Highlight Favorites #34

Closed murfguy closed 6 years ago

murfguy commented 6 years ago

Requirements

Description of the Change

Adds features related to the ability to provide highlights to favorited streamers while browsing, and to also be able to add/remove favorite streamers from a streamer's personal page.

Benefits

Users will now be able to easily find their favorite streamers from the browsing, and additionally be able to edit favorite status without needing to visit the options dropdown.

Possible Drawbacks

This feature cannot be turned off at the moment, and additional development is required to make that an adjustable option for users.

Applicable Issues

Unfollowing a streamer does not automatically remove their favorite status. Highlights are only present on browsing page, and streamer pages. Expansions to functionality are planned for additional highlighting in chat and team pages.

Note: Please be aware that we may require changes (in code or in the UI) if we believe they are required to meet the vision and standards of Elixr. Don't take suggestions for tweaks personally, we are all simply trying to make Elixr the best that it can be :)

murfguy commented 6 years ago

Roger that. Do you want me to go ahead and make these changes myself?

I was unaware that JS had finally implemented default values in function parameters. Thank goodness. That always annoyed the hell out of me.

murfguy commented 6 years ago

I had just copied other API calls present in the code, but I'll modify those calls to getJSON in future iterations.

murfguy commented 6 years ago

And thanks for the feedback.

ebiggz commented 6 years ago

@murfguy If you wanna update any of these things, go for it. I'll wait to merge. You're right - we arent consistent in the injected script in terms of how we do http requests. I hadn't noticed we use a XML Request there too, I'll have to update that. (We do use them in the Options page alot, however, because we dont have access to jquery there so that's fine.)

murfguy commented 6 years ago

I've still got the co-stream issue to tackle. It's a bit buggy there but the buttons show up so we'll see what happens. If you want to go ahead and merge with what we have, go ahead. I'll take care of syntax cleanup in my next pull.

ebiggz commented 6 years ago

Awesome! I'll get this badboy merged.