Filling out the below template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
Description of the Change
This update contains modifications that enable the detection of a co-stream, gets the active set of co-streamers and appropriately places favorite buttons in co-streamer menus based on follow status. All detection of co-stream, co-streamers and their followed status is achieved by way of Mixer API calls. Favorite buttons on co-streams work in the same fashion as solo-streamers for end users.
Functions that were in use for solo-streamer favorite button injection have been modified to understand the required DOM for both solo-streamers and co-stream pages.
Additional adjustments have been made to help solidify the methods by which favorite buttons are injected and operate in order to appropriately accommodate co-streamer favoriting. And general tidying of function placement, comments and log statements have also been done.
Benefits
This now enables favoriting from all streamer pages as well as provides a reliable method of co-stream detection that is available to all MixrElixr developers.
Possible Drawbacks
None that come to mind at present.
Applicable Issues
No extra development was done on saving of options related to these features. There should be discussion of which related options and features can be toggled.
While co-stream detection functions are open for all developers, their implementation in 'loadStreamerPage' was solely created around the favorite buttons. It would be worth investigating on how best to differentiate and implement co-stream specific injections.
ebiggz
commented
6 years ago
Requirements
Description of the Change
This update contains modifications that enable the detection of a co-stream, gets the active set of co-streamers and appropriately places favorite buttons in co-streamer menus based on follow status. All detection of co-stream, co-streamers and their followed status is achieved by way of Mixer API calls. Favorite buttons on co-streams work in the same fashion as solo-streamers for end users.
Functions that were in use for solo-streamer favorite button injection have been modified to understand the required DOM for both solo-streamers and co-stream pages.
Additional adjustments have been made to help solidify the methods by which favorite buttons are injected and operate in order to appropriately accommodate co-streamer favoriting. And general tidying of function placement, comments and log statements have also been done.
Benefits
This now enables favoriting from all streamer pages as well as provides a reliable method of co-stream detection that is available to all MixrElixr developers.
Possible Drawbacks
None that come to mind at present.
Applicable Issues
No extra development was done on saving of options related to these features. There should be discussion of which related options and features can be toggled.
While co-stream detection functions are open for all developers, their implementation in 'loadStreamerPage' was solely created around the favorite buttons. It would be worth investigating on how best to differentiate and implement co-stream specific injections.