crowbartools / MixrElixr

Browser extension that enhances your Mixer viewing experience with custom emotes, new features, and a ton of options.
https://mixrelixr.com
GNU General Public License v3.0
23 stars 7 forks source link

Hotfixing auto close interactive board #61

Closed FierySama closed 5 years ago

FierySama commented 5 years ago

Description of the Change

This temporarily hotfixes interactive boards not auto closing with the option checked.

Benefits

Interactive auto closes again!

Possible Drawbacks

The first page load on the entire site doesn't auto close, but every additional visited stream auto closes for that session. Couldn't wrap my head around why, maybe a waitForElement would work here?

Applicable Issues

Will not work for costreams that have multiple mixplays up and running. I don't know how to track that yet.

Also, if mixplay restarts or resprings, it will not auto close that. That would require some sort of loop, which would then need another check to make sure it's not the user opening the board to prevent auto closing unintentionally.

ebiggz commented 5 years ago

@FierySama Thanks for starting on this!

I started investigating the if( $('.toggle-interactive .icon-check_box_outline_blank').length >= 0){ line you referenced and ended up recreating the fix using some of the code you did here while also adding some more logic for handling costreams.

If you are curious how I went about that, check out this commit: https://github.com/crowbartools/MixrElixr/commit/440406ef3118ce51cfa148f58a48a3ee9aa87db7

Thanks again for getting the ball rolling on this fix. Keep up the awesome work!

FierySama commented 5 years ago

@FierySama Thanks for starting on this!

I started investigating the if( $('.toggle-interactive .icon-check_box_outline_blank').length >= 0){ line you referenced and ended up recreating the fix using some of the code you did here while also adding some more logic for handling costreams.

If you are curious how I went about that, check out this commit: 440406e

Thanks again for getting the ball rolling on this fix. Keep up the awesome work!

Glad to help in any way possible <3