search

crowbartools / MixrElixr

Browser extension that enhances your Mixer viewing experience with custom emotes, new features, and a ton of options.
https://mixrelixr.com
GNU General Public License v3.0
23 stars 7 forks source link

Auto Theater Mode #62

Closed FierySama closed 5 years ago

FierySama commented 6 years ago

Description of the Change

There's now an auto theater mode! If you're like me, I almost always click theater mode right away. Hopefully people find this useful! image

Alternate Designs

One that accounts for those who want Auto Theater, but also don't want MixPlay to turn off when entering theatermode.

Benefits

Less hassle, more convenience for people who already click the Theater mode button anyways.

Possible Drawbacks

1) Even with "auto close interactive" unchecked-- when auto theater mode is checked, and toggles theater mode, it closes MixPlay as well. I think this is intentional on the design of theater mode, but I'm not sure if this is what some users will want. I don't know enough to make an additional toggle to account for this

Applicable Issues

1) When auto theater mode is on, opening the MixrElixr settings toggles theater mode off again. I have no idea why yet.

FierySama commented 6 years ago

Oh no, I just recognized a no no. If you load up an offline page, it enables theater mode with no way out. :(

FierySama commented 6 years ago

Apologies :/ I guess I didn't test enough things out for this feature. One more issue, past streams cut out the 1/8th of the player at the bottom, hiding the controls to exit theater mode unless you scroll down.

I should have accounted for the above two issues by making a check to see if the stream was offline, and two: to not turn on theater mode during past streams automatically. I would love to yank my pull request and fix these issues, but I'm out of time for a few weeks. Close this or improve on it as you wish, thanks for reading and assisting me with my sloppy work! :)

ebiggz commented 5 years ago

Hi @FierySama ! Thank you for taking the time to take a stab at a great feature that I hadn't even thought of before. I clearly spaced and forgot this PR existed until tonight...8 months later. I apologize for that. Due to the amount of changes since you submitted this, I went ahead and manually implemented this feature in the current dev branch, using this PR as a reference.

The commit is here: https://github.com/crowbartools/MixrElixr/commit/3a037788f9fe06e42a4c20c8dc502d4e96a9a553

Thanks again for contributing! Looking forward to seeing what you cook up next :)