Open FierySama opened 4 years ago
This works fine on Chrome, however on Firefox while it works it brings up this menu each time.
Will keep this PR open if anyone likes the concept enough
It's terrible. since there is no check to see whether you're typing in chat, Shift + T means if you capitalize things in sentences often, you'll be toggling theater mode and off. This is the biggest flaw in this PR! ahhh!!!
This is a great idea Fiery! I wonder if Shift + Alt + T or something to that effect would fit all browser types
I wonder if Shift + Alt + T or something to that effect would fit all browser types
The AltLeft
key used will work with iOS's options key aswell, if that is what you were musing
Alt + T key combo now toggles theater mode on and off! Escape still works too separately to exit theatermode
Description of the Change
Repurposed the escape event listener code to create a key combination of Alt + T that toggles theatermode on and off!
Updated tooltip![image](https://user-images.githubusercontent.com/23622992/73704939-6f5cee00-46a9-11ea-803a-2eb7ef9cb7a8.png)
Slowed down this toast by 1/4 of a second for slower readers, feel free to revert this![image](https://user-images.githubusercontent.com/23622992/73705024-961b2480-46a9-11ea-8550-d9122bbbb229.png)
Benefits
Possible Drawbacks
I admit I have no idea how this will function on MacOs. I used this https://www.w3.org/TR/uievents-code/#keyboard-key-codes . I assume alt/option + T on mac may still do the same thing?
Credit
SReject helped me remove redundant code before this commit, thanks Reject!