search

crowbartools / firebot-custom-scripts-types

TypeScript types for Firebot's Custom Scripts
6 stars 11 forks source link

Add: CurrencyDB Module #13

Closed patchtechtwitch closed 3 years ago

patchtechtwitch commented 3 years ago

CurrencyDB module for #2

patchtechtwitch commented 3 years ago

Updated!

pirak commented 3 years ago

GitHub shows that you force-pushed an updated commit, but It doesn’t seem like anything in the code has changed. Did the changes not get added to the commit?

patchtechtwitch commented 3 years ago

GitHub shows that you force-pushed an updated commit, but It doesn’t seem like anything in the code has changed. Did the changes not get added to the commit?

Yup, looks like I didn't add the file before I did the commit amend. Fixed

pirak commented 3 years ago

Perfect. Looks good!

patchtechtwitch commented 3 years ago

Didn't see the index.d.ts conflict. Resolved.

patchtechtwitch commented 3 years ago

Looks great, thank you both! I know the currencyDb probably wasn't a fun one to parse and make types for, so I really appreciate it.

haha, no worries :D It was a good one for me to learn with :D