crowbarz / ha-sql_json

Updated SQL integration for Home Assistant that supports JSON attributes
7 stars 2 forks source link

Improve GitHub Actions #1

Closed KTibow closed 1 year ago

KTibow commented 4 years ago

I recently announced ha-blueprint:

https://community.home-assistant.io/t/made-a-custom-integration-or-card-ive-created-an-all-in-one-github-action-for-you/235041 This makes it so it auto-checks for HACS, hassfest, and flake8 so you won't have to worry about it being invalid.

KTibow commented 4 years ago

Mind pulling this in @crowbarz?

crowbarz commented 4 years ago

@KTibow on initial review this looks like a worthwhile effort, though I think it's prudent to perform some due diligence first. I note that you really do mean "recent" in a literal sense (9 days ago!) so I have a few questions to help me better understand the goals of your code and evaluate whether to move to it from the hassfest GitHub action currently in use and endorsed by balloob:

Thanks.

KTibow commented 4 years ago
  1. Yes, here you go: https://github.com/search?q=ha-blueprint+-user%3AKTibow&type=code
  2. Could you clarify a bit? Basically it shows an error when you push a commit that makes the Python invalid or Hassfest invalid. It can also provide you with some tips on improving your code, from wemake-python-styleguide and flake8.
crowbarz commented 4 years ago

To clarify my second question, I wanted to know if your future plan for this action was to get it adopted by the HACS or HA code owners as a standard requirement for new integrations submitted into HACS and/or HA core.

After reviewing the action in more depth, I have some more questions/comments:

KTibow commented 4 years ago

I don't have this plan. I just wanted to make something that anybody could use. I currently have pending PRs to add a link to the HACS GitHub Actions doc in the hacs/default PR template, and to add ha-blueprint in the tip box for the HACS GitHub Actions doc. I have no plans to do anything for the core, they already have their own set of rules which I based mine off of.