Delete submission is not triggering a leaderboard refresh?

crowdAI / crowdai

Fighting for Open Science with Open Data

https://www.crowdai.org

GNU Affero General Public License v3.0

149 stars 32 forks source link

Delete submission is not triggering a leaderboard refresh? #1040

Closed scarroll32 closed 6 years ago

scarroll32 commented 6 years ago

To be investigated

scarroll32 commented 6 years ago

Seems to be working OK for me. Closed.

bednarikjan commented 6 years ago

The issue still persists, I've just tried within the following challenge: https://www.crowdai.org/challenges/epfl-ml-road-segmentation.

Steps: 1) Submissions -> Create submission -> Upload file and confirm 01_submission 02_leaderboard

2) Delete Submissions

The submission disappears from the list of submissions (expected behaviour)

3) Leaderboard

The entry is still there.
If one clicks on the link within Entries column, a 500 error page appears.

scarroll32 commented 6 years ago

OK, I've found the root cause: this issue occurs when the last submission has been deleted, and then this code causes the process to exit.

When this line is removed, downstream code fails due to the inability to find a submission to calculate the window, and other downstream code will also fail.

It seems the best thing to do is to delete the leaderboard when the last submission has been deleted ... but I will need to think about this a bit.

scarroll32 commented 6 years ago

https://github.com/crowdAI/crowdai/pull/1043/commits/52e4eff3e431e53dcf9affdb4689d290d65598f4

scarroll32 commented 6 years ago

Implemented. Thank you @bednarikjan for the detailed bug report. For the entries left in the existing leaderboards, a one-time cleanup will be to add a submission, then delete it.

That will clear the leaderboards without needing to access the back-end directly.