search

crowdAI / crowdai

Fighting for Open Science with Open Data
https://www.crowdai.org
GNU Affero General Public License v3.0
149 stars 32 forks source link

Post challenge flag is set for create only #332

Closed scarroll32 closed 7 years ago

scarroll32 commented 7 years ago

The post challenge flag should only be set when a submission is created, not when it is later updated for a regrade.

https://github.com/crowdAI/crowdai/blob/master/app/models/submission.rb

spMohanty commented 7 years ago

Also, we need to rethink how to visually show post-challenge submissions. I will add this to the discussion on Monday with Jason, if we have some extra time at the end.

OpenSNP challenge will continue accepting submissions starting tomorrow (30th September)

scarroll32 commented 7 years ago

Have implemented this assuming post challenges are also limited by the same number of submissions. If this is not required for a specific challenge, then the limit can be removed after the end of the challenge (by setting it to zero).

scarroll32 commented 7 years ago

Incorporated into #327