crowdAI / marLo

Multi Agent Reinforcement Learning using MalmÖ
MIT License
245 stars 46 forks source link

Tests !!!!!!!!!!! #46

Open spMohanty opened 6 years ago

spMohanty commented 6 years ago

Currently we have absolutely no tests !!

And we definitely do need good test coverage as the code base starts accepting contributions from multiple users.

This issue could use a little bit of love from the community ! (And this could be a great way for someone to understand the internals of the library too !)

EC2EZ4RD commented 6 years ago

I am willing to make some contributions, so how and what should I do?

idvhfd commented 6 years ago

Hey @EC2EZ4RD,

Thanks for taking the time. What I believe Mohanty means is that we are very happy with -any- test coverage submissions from the community. Therefore, you should be able to push whatever you wish through. We have 0.00f tests!

That being said, a good starter test should be to run the experiments by stubbing out the step phase and other open ends. This will help tremendously in ensuring future releases do not break people's ability to run the internals of the mod.

Running and testing each environment should be a next test priority. Ideally, we'd be able to recursively find and test all environments listed in the envs directory.

Sometimes on Win10, the game spazzes out when you run a map and focus on another window while it loads, causing the mod to presumably run in the background, but the window becomes impossible to maximize, therefore running a client and ensuring that it behaves as expected (i.e. correctly implements the given resolution, environment and agent parameters for example) would be another great contribution.

Everything needs to be automatically tested!

I'll put down a "tests" folder in the base directory on Master so you can all follow that pattern. I'll also try to follow up with some coverage later this week or the next if time allows.