Documentation for FindTheGoal

crowdAI / marLo

Multi Agent Reinforcement Learning using MalmÖ

MIT License

244 stars 46 forks source link

Documentation for FindTheGoal #55

Open rocanaan opened 5 years ago

rocanaan commented 5 years ago

Hello,

I was looking at issue #32 and the documentation for the environments and realized the FindTheGoal environment is one of the few environments with no documentation.

Since this is the environment that will be used for the first phase, I would like to know if there is an ETA for the documentation on this environment to be made available.

If I may make some suggestions, I would like to know:

If the room is always flat or if the goal may be occluded by walls (making it somewhat like a maze)
What materials are possible for the goal block and for the rest of the room
If there might be obstacles such as lava, holes, steps, etc.

Thank you very much!

spMohanty commented 5 years ago

@rocanaan : You are right, there was a small issue. While I fixed it, I realised the docstirngs for FindTheGoal are not written. @idvhfd confirmed that he will be adding them soon.

And wrt your questions,

the room will always be flat, and goal will not be occluded by walls
the materials for goal block could be : gold_ore diamond_ore redstone_ore
there will be no obstacles.

@idvhfd : This is what needs a touch up : https://github.com/crowdAI/marLo/blob/master/marlo/envs/FindTheGoal/main.py#L12

ludns commented 5 years ago

@spMohanty How do you configure the env to have gold_ore diamond_ore redstone_ore being chosen randomly instead of the usual gold block?

spMohanty commented 5 years ago

@justinglibert : Its defined here. I might be misinterpreting it. @rdgain : Can you comment on this ?

ludns commented 5 years ago

@spMohanty what I mean is that when I run the environment I never see any block other than the gold one. I looked at the mission file and didn't find a parameter to set that up. If during evaluation our agent can encounter non gold block, how are we supposed to set our local environment to reproduce this diversity?

idvhfd commented 5 years ago

Apologies for the delay, I was unable to attend this earlier. I added a brief description in the same style as the previous ones (awaiting confirm and pull). Thanks for pointing this out and please do accept my apologies for creating this situation. Let me know if anything else like this is needed.

@justinglibert the seed is being passed as a parameter, that's where the block comes from. Waiting on @spMohanty for exact path to that bit as I can't look for it right now.