search

crowdcover / congo-mines-app

Rails app for the CongoMines project
1 stars 0 forks source link

add tilelayers to map page #51

Closed jameslaneconkling closed 9 years ago

jameslaneconkling commented 9 years ago

on dropdown click, add a new tilelayer to the map and remove all existing tilelayers (see dropdowns on template site map page, though if necessary, recreate the dropdown as you see fit.

tilelayers should be defined in maplayer table (see #40).

I can write the actual leaflet functions to add/remove each tilelayer, once the dropdown is created, w/ event handlers, etc.

charleshuang80 commented 9 years ago

@jameslaneconkling the dropdown is created, but I don't know what layers to try and pull with (or test with)

jameslaneconkling commented 9 years ago

Once #40 is fixed, all tilelayers should populate the Maps Dropdown.

Testing shouldn't be an issue. Just make dummy data for your local database.

Label should of course be the link test. Best practice is to pass the map-id as an html data attribute. E.g.

<a href="#" data-id="{mapid}">{label}</a>

charleshuang80 commented 9 years ago

So we're just populating the dropdown from the table, and not talking about actually rendering anything, right?

jameslaneconkling commented 9 years ago

Yeah. I'll get the layers to render w/ leaflet

On Wed, Jun 3, 2015 at 3:08 PM Charles Huang notifications@github.com wrote:

So we're just populating the dropdown from the table, and not talking about actually rendering anything, right?

— Reply to this email directly or view it on GitHub https://github.com/crowdcover/congo-mines-app/issues/51#issuecomment-108628991 .

charleshuang80 commented 9 years ago

done