search

crowdcover / congo-mines-app

Rails app for the CongoMines project
1 stars 0 forks source link

topics pages urls should be the name of topic #85

Closed jameslaneconkling closed 9 years ago

jameslaneconkling commented 9 years ago

e.g. http://188.166.93.154/pages/10

should be

http://188.166.93.154/human_rights

(or whatever the topic name happens to be)

charleshuang80 commented 9 years ago

@jameslaneconkling it is setup for the url to be: /pages/5-Human_Rights Does that work?

jameslaneconkling commented 9 years ago

Is it possible to remove the '5-'? This requires that the name be unique, which it probably should be anyway.

On Fri, May 29, 2015 at 2:56 AM, Charles Huang notifications@github.com wrote:

@jameslaneconkling https://github.com/jameslaneconkling it is setup for the url to be: /pages/5-Human_Rights Does that work?

— Reply to this email directly or view it on GitHub https://github.com/crowdcover/congo-mines-app/issues/85#issuecomment-106643949 .

charleshuang80 commented 9 years ago

@jameslaneconkling how important/necessary is it to take out the preceding numbers for this issue and drc companies?

It is doable, but I will have to do a database change and maybe coordinate with @markmcdonald51 on populating a column for the urls. More importantly, it will change how the urls/references are treated in all the views (potentially in the admin part also).

jameslaneconkling commented 9 years ago

Not a priority, though it would be nice to have.

On Mon, Jun 1, 2015 at 3:20 PM Charles Huang notifications@github.com wrote:

@jameslaneconkling https://github.com/jameslaneconkling how important/necessary is it to take out the preceding numbers for this issue and drc companies?

It is doable, but I will have to do a database change and maybe coordinate with @markmcdonald51 https://github.com/markmcdonald51 on populating a column for the urls. More importantly, it will change how the urls/references are treated in all the views (potentially in the admin part also).

— Reply to this email directly or view it on GitHub https://github.com/crowdcover/congo-mines-app/issues/85#issuecomment-107734399 .

charleshuang80 commented 9 years ago

ok, let's discuss when we talk next. As I mentioned, doable but might be best to wait until there is more time to test all links