Closed mateomtb closed 10 years ago
Still needs some work, just rendering the new shortcode is not enough, we need to process the images similar to how the gallery class is doing it now.
images sized by default gallery code
images using do_shortcode( $usercode ) vertical thumb is wrong and images do not fill the gallery stage.
You may need to run the "regenerate thumbnails" plugin.
cool i'll look for that
Sweet, that worked!
Cool, looking forward to testing this out in the near future. I think we may end up wanting to remove the tabindex altogether, but will see.
I meant to remove those completely, nothing tabs on those post editor pages as expected!
I'm seeing a variety of other refinements that need to be made before this would be ready to merge into the develop
branch. As such, I've created a feature/gallery-shortcode
branch - can you please open the pull request against that branch?
Some of the things I've noted in an initial review on my local:
new pull request sent
Excellent, thanks!
A stab at adding the option to override the default [gallery] tag behavior which displays all images uploaded/attached to the post. The user can check "Use alternate image id's" and pass comma separated ids of any images to override the default [gallery] behavior. This is using the WordPress shortcodeatts{gallery} filter to manipulate the gallery output.