crowdfavorite / wp-post-formats

An admin interface and structured post meta for WordPress post formats.
362 stars 78 forks source link

Gallery radio buttons #50

Closed mateomtb closed 10 years ago

mateomtb commented 10 years ago

A stab at adding the option to override the default [gallery] tag behavior which displays all images uploaded/attached to the post. The user can check "Use alternate image id's" and pass comma separated ids of any images to override the default [gallery] behavior. This is using the WordPress shortcodeatts{gallery} filter to manipulate the gallery output. screen shot 2014-08-22 at 2 31 32 pm

mateomtb commented 10 years ago

Still needs some work, just rendering the new shortcode is not enough, we need to process the images similar to how the gallery class is doing it now.

images sized by default gallery code

defaultcode

images using do_shortcode( $usercode ) vertical thumb is wrong and images do not fill the gallery stage.

usercode

alexkingorg commented 10 years ago

You may need to run the "regenerate thumbnails" plugin.

mateomtb commented 10 years ago

cool i'll look for that

mateomtb commented 10 years ago

Sweet, that worked! newthumbs

alexkingorg commented 10 years ago

Cool, looking forward to testing this out in the near future. I think we may end up wanting to remove the tabindex altogether, but will see.

mateomtb commented 10 years ago

I meant to remove those completely, nothing tabs on those post editor pages as expected!

alexkingorg commented 10 years ago

I'm seeing a variety of other refinements that need to be made before this would be ready to merge into the develop branch. As such, I've created a feature/gallery-shortcode branch - can you please open the pull request against that branch?

Some of the things I've noted in an initial review on my local:

mateomtb commented 10 years ago

new pull request sent

alexkingorg commented 10 years ago

Excellent, thanks!