crowdin / crowdin-api-client-dotnet

.NET client library for Crowdin API
https://www.nuget.org/packages/Crowdin.Api/
MIT License
52 stars 27 forks source link

Projects API: `qaChecksIgnorableCategories` support #113

Closed andrii-bodnar closed 1 year ago

andrii-bodnar commented 1 year ago

Crowdin Rest API now supports the qaChecksIgnorableCategories field on the Projects API.

This field allows you to retrieve the list of QA Check categories that can be ignored for a Crowdin project.

Affected API methods:

It should be reflected in this API client and the corresponding unit tests should be updated.

innomaxx commented 1 year ago

@andrii-bodnar type of qaChecksIgnorableCategories is the same that of qaCheckCategories? Seems like props are the same

innomaxx commented 1 year ago

Also in docs I noticed new properties in qaCheckCategories model that are also exist in qaChecksIgnorableCategories But these props are not available in API client yet. Should we also add them?

image

andrii-bodnar commented 1 year ago

@andrii-bodnar type of qaChecksIgnorableCategories is the same that of qaCheckCategories? Seems like props are the same

Please provide the API methods as a reference, probably it's the same, but need to check additionally

andrii-bodnar commented 1 year ago

Also in docs I noticed new properties in qaCheckCategories model that are also exist in qaChecksIgnorableCategories But these props are not available in API client yet. Should we also add them?

Nice catch, these are new types that have been added recently, they should be reflected in the API client as well

innomaxx commented 1 year ago

Please provide the API methods as a reference, probably it's the same, but need to check additionally

It's Add Project method

andrii-bodnar commented 1 year ago

type of qaChecksIgnorableCategories is the same that of qaCheckCategories? Seems like props are the same

yes, it's the same