search

crowdin / crowdin-api-client-dotnet

.NET client library for Crowdin API
https://www.nuget.org/packages/Crowdin.Api/
MIT License
53 stars 26 forks source link

Create Task API: new `includePreTranslatedStringsOnly` parameter #163

Closed andrii-bodnar closed 1 year ago

andrii-bodnar commented 1 year ago

API Reference: Add Task

The API response will also include this new field.

This is relevant for both the crowdin.com and Crowdin Enterprise APIs.

The new parameter should also be reflected in this API client.

Riju-bak commented 1 year ago

Hi @andrii-bodnar, can I take this up?

andrii-bodnar commented 1 year ago

Hi @Riju-bak, sure, thank you!

Riju-bak commented 1 year ago

@andrii-bodnar Can you please look at the description of this draft PR, to see if I correctly understood the problem.

Also, I'm not sure how to test requests to add tasks. I had a look at the tests in TasksApiTests.cs. It seems that the tests within this file only check whether the AddTaskRequest object is getting serialized correctly.

andrii-bodnar commented 1 year ago

Hi @Riju-bak, thanks a lot for the contribution! The PR looks good to me. You probably need to add this new parameter to the existing Unit test and that's it. @innomaxx please correct me if I'm wrong.

Riju-bak commented 1 year ago

@andrii-bodnar @innomaxx I have opened this PR, but unable to add reviewers, so just posting it here.