Apply Pre-Translation API: add labels support

crowdin / crowdin-api-client-dotnet

.NET client library for Crowdin API

https://www.nuget.org/packages/Crowdin.Api/

MIT License

53 stars 26 forks source link

Apply Pre-Translation API: add labels support #195

Closed andrii-bodnar closed 11 months ago

andrii-bodnar commented 11 months ago

Crowdin has recently added a possibility to Pre-Translate strings by labels. However, the new parameters are not supported in this API client.

The new labelIds and excludeLabelIds parameters should be added to the "Apply Pre-Translation" method in this API client.

API Reference:

Apply Pre-Translation
Pre-Translation Status (The attributes field now contains the new fields as well)

Riju-bak commented 11 months ago

@andrii-bodnar I have created a draft PR for now since the response-schema in API reference for Pre-Translation-Status doesn't contain the labelIds and excludeLabelIds parameters within the attributes field.

Is the doc yet to be updated? Just want to be sure.

andrii-bodnar commented 11 months ago

@Riju-bak thanks for pointing this out!

I just checked it with Postman and the new fields are presented in the response. It seems that the documentation response sample hasn't been updated for this method, already passed it to the team.

Riju-bak commented 11 months ago

Got it. Switched the PR from draft to "ready for review".