search

crowdin / crowdin-api-client-dotnet

.NET client library for Crowdin API
https://www.nuget.org/packages/Crowdin.Api/
MIT License
53 stars 26 forks source link

fix: BuildStatus description casing inconsistency. #201

Closed PatrickMNL closed 11 months ago

PatrickMNL commented 11 months ago

Purposed fix for #167.

andrii-bodnar commented 11 months ago

Honestly, I'm already not sure if this is a good idea :(

It adds extra complication for end users. Maybe it would be better to handle this inconsistency with the "temporary" fix? But it will no longer be temporary

We'll just hide this API design mistake from the end users.

PatrickMNL commented 11 months ago

@andrii-bodnar I definitely agree on that part, I don't mind accepting the 'workaround' as permanent fix. We can make it a little prettier by swapping around the descriptions. (Making 'in_progress' the default and 'inProgress' the one fixed by the workaround).

codecov[bot] commented 11 months ago

Codecov Report

Merging #201 (8198e81) into main (f45d418) will increase coverage by 5.66%. Report is 65 commits behind head on main. The diff coverage is 87.98%.

@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
+ Coverage   50.38%   56.04%   +5.66%     
==========================================
  Files         277      326      +49     
  Lines        3688     4988    +1300     
==========================================
+ Hits         1858     2795     +937     
- Misses       1830     2193     +363
Files Coverage Δ
src/Crowdin.Api/Bundles/AddBundleRequest.cs 100.00% <100.00%> (ø)
src/Crowdin.Api/Bundles/Bundle.cs 100.00% <100.00%> (ø)
src/Crowdin.Api/Bundles/BundlePatch.cs 100.00% <ø> (ø)
....Api/Core/Converters/FileExportOptionsConverter.cs 84.62% <100.00%> (+6.84%) :arrow_up:
....Api/Core/Converters/FileImportOptionsConverter.cs 76.48% <100.00%> (+20.92%) :arrow_up:
...e/Converters/ProjectFileFormatSettingsConverter.cs 96.52% <100.00%> (-0.09%) :arrow_down:
src/Crowdin.Api/Core/JsonParser.cs 90.25% <100.00%> (+1.36%) :arrow_up:
...rowdin.Api/Distributions/AddDistributionRequest.cs 100.00% <100.00%> (ø)
src/Crowdin.Api/Distributions/Distribution.cs 100.00% <100.00%> (+44.45%) :arrow_up:
src/Crowdin.Api/Distributions/DistributionPatch.cs 100.00% <ø> (ø)
... and 92 more

... and 57 files with indirect coverage changes

PatrickMNL commented 11 months ago

@andrii-bodnar Updated the PR accordingly.

andrii-bodnar commented 11 months ago

@PatrickMNL great, looks good to me, thanks a lot!