search

crowdin / crowdin-api-client-dotnet

.NET client library for Crowdin API
https://www.nuget.org/packages/Crowdin.Api/
MIT License
50 stars 27 forks source link

feat: String based api support (Clients, Bundles, Distributions, Labels, Machine Translations) #224

Closed Zahid92 closed 4 months ago

Zahid92 commented 4 months ago

Yet to complete, Initially I was trying to get it done in a single chunk, realized my mistake and now will implement in small chunks one thing at a time

214

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 52.70270% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 58.65%. Comparing base (f45d418) to head (5f7cd77). Report is 85 commits behind head on main.

Files Patch % Lines
...wdin.Api/Distributions/DistributionsApiExecutor.cs 33.34% 10 Missing :warning:
...c/Crowdin.Api/ProjectsGroups/FileFormatSettings.cs 0.00% 8 Missing :warning:
src/Crowdin.Api/Clients/ClientsApiExecutor.cs 66.67% 5 Missing :warning:
...pi/Distributions/DistributionStringBasedRelease.cs 0.00% 5 Missing :warning:
.../Crowdin.Api/MachineTranslationEngines/MtEngine.cs 0.00% 5 Missing :warning:
src/Crowdin.Api/Labels/Label.cs 0.00% 1 Missing :warning:
src/Crowdin.Api/Labels/LabelsApiExecutor.cs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #224 +/- ## ========================================== + Coverage 50.38% 58.65% +8.27% ========================================== Files 277 347 +70 Lines 3688 5368 +1680 Branches 0 435 +435 ========================================== + Hits 1858 3148 +1290 - Misses 1830 2187 +357 - Partials 0 33 +33 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

andrii-bodnar commented 4 months ago

@Zahid92 thank you! Please let me know when I can start reviewing this PR.

Zahid92 commented 4 months ago

Hi @andrii-bodnar, didn't get much time to work more onto this. Could you review this much of work and once I get some time will continue with the rest of it.

andrii-bodnar commented 4 months ago

@Zahid92 Thanks for letting me know!

Could you please summarize in the original issue what has been done and what still needs to be done?

Zahid92 commented 4 months ago

Hi @andrii-bodnar, here the list for whats done and whats remaining.

String based support for :

Remaining String based support for:

andrii-bodnar commented 4 months ago

@Zahid92 thank you!