search

crowdin / crowdin-api-client-dotnet

.NET client library for Crowdin API
https://www.nuget.org/packages/Crowdin.Api/
MIT License
50 stars 27 forks source link

fix(api): issue 239 int overflow exception fix #240

Closed A-Sosnovsky closed 1 month ago

A-Sosnovsky commented 1 month ago

Updated storageId field type everywhere because of int type overflow

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.52%. Comparing base (f45d418) to head (bcde425). Report is 93 commits behind head on main.

Files Patch % Lines
src/Crowdin.Api/Glossaries/GlossaryImportStatus.cs 0.00% 1 Missing :warning:
...rc/Crowdin.Api/Glossaries/ImportGlossaryRequest.cs 0.00% 1 Missing :warning:
...Crowdin.Api/Screenshots/UpdateScreenshotRequest.cs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #240 +/- ## =========================================== + Coverage 50.38% 60.52% +10.14% =========================================== Files 277 373 +96 Lines 3688 5751 +2063 Branches 0 468 +468 =========================================== + Hits 1858 3480 +1622 - Misses 1830 2233 +403 - Partials 0 38 +38 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

A-Sosnovsky commented 1 month ago

@andrii-bodnar thanks for approving. Could you create new release with this fix?

andrii-bodnar commented 1 month ago

Done - https://github.com/crowdin/crowdin-api-client-dotnet/releases/tag/2.23.1