Closed EvilKot closed 2 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 63.46%. Comparing base (
f45d418
) to head (8785048
). Report is 115 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@EvilKot, thank you! Passing it over to @innomaxx for review as well.
@andrii-bodnar @EvilKot nice work, but I suggest a slightly different approach.
To refactor the namespaces, we can make the following changes:
Crowdin.Api.Tests
to Crowdin.Api.UnitTesting
(it looks better IMO).Crowdin.Api.UnitTesting.Tests.{ApiSectionName}
folders
Core serialization and other tests place in root of Crowdin.Api.UnitTesting.Tests
Crowdin.Api.UnitTesting.Resources
folder.Crowdin.Api.UnitTesting
folder.Hey, sorry for a long reply.
It seems i've messed up a bit with commit history trying to merge latest changes 😬 Also not quite sure why files such Readme.md and two files in Crowdin.Api.Translations are listed in the changes. I've created new PR #278 with all the changes applied from scratch in a single commit, just in case.
1-4 Done
5 - files under Crowdin.Api.UnitTesting
, Crowdin.Api.UnitTesting.Resources
, Crowdin.Api.UnitTesting.Tests
looks fine, Crowdin.Api.UnitTesting.Tests.{ApiSectionName}
and below, like Crowdin.Api.UnitTesting.Tests.Webhooks.Organization
partially checked, renaming was done by IDE.
Answered in #278
Closes #272
Reaming folder with test utilities to
Testing/
instead of/Core
to not to conflict with folder structure defined in/src
.Should be good enough. Alternatively all tests could be moved into nested directory to avoid further folder conflicts, or even all test utilities and resources could be moved to a new project.