search

crowdin / crowdin-api-client-java

Java client library for Crowdin API
https://jitpack.io/#crowdin/crowdin-api-client-java
MIT License
65 stars 44 forks source link

Add more Unit tests for the `core` package #191

Closed andrii-bodnar closed 4 months ago

andrii-bodnar commented 11 months ago

The core package has low code coverage by Unit tests. We need to add more Unit tests to cover the code.

References:

debanjanc01 commented 11 months ago

Hey @andrii-bodnar I can pick this up.

andrii-bodnar commented 11 months ago

Hi @debanjanc01, any updates on this?

debanjanc01 commented 11 months ago

Hey @andrii-bodnar , I'm still working on it, although my speed has been super slow.

debanjanc01 commented 10 months ago

Hey @andrii-bodnar I'm unassigning myself in case someone else wants to pick this up. I'm not getting the time lately to polish my changes and push them.

DecarteAdam commented 4 months ago

Hi, What is expected code coverage?

andrii-bodnar commented 4 months ago

@DecarteAdam I think that around 80-90% for the core package would be good

DecarteAdam commented 4 months ago

Hi @andrii-bodnar , I've just pushed. Can you assign this to me pls ?

DecarteAdam commented 4 months ago

Hey @andrii-bodnar can you link this issue to my PR?

andrii-bodnar commented 4 months ago

Hey @DecarteAdam, thank you!

Will review it soon