search

crowdin / crowdin-api-client-java

Java client library for Crowdin API
https://jitpack.io/#crowdin/crowdin-api-client-java
MIT License
65 stars 44 forks source link

Add more Unit tests for the `reports` package #195

Closed andrii-bodnar closed 4 months ago

andrii-bodnar commented 11 months ago

The reports package has low code coverage by Unit tests. We need to add more Unit tests to cover the code.

References:

chinmaym07 commented 11 months ago

Hey @andrii-bodnar , can I contribute to this ?

andrii-bodnar commented 11 months ago

@chinmaym07 sure, thank you!

andrii-bodnar commented 11 months ago

Hi @chinmaym07, any updates on this?

DecarteAdam commented 4 months ago

Hi! What is expected code coverage?

andrii-bodnar commented 4 months ago

@DecarteAdam I think that around 80-90% for models would be good

DecarteAdam commented 4 months ago

Hey @andrii-bodnar Can you assign this to me? Thanks

DecarteAdam commented 4 months ago

Hey @andrii-bodnar Pushed! Can you link this issue to my PR?

andrii-bodnar commented 4 months ago

Hey @DecarteAdam, thank you!

Will review it soon