search

crowdin / crowdin-api-client-java

Java client library for Crowdin API
https://jitpack.io/#crowdin/crowdin-api-client-java
MIT License
64 stars 40 forks source link

Report Settings Template: add the `isPublic` property support #201

Closed andrii-bodnar closed 9 months ago

andrii-bodnar commented 9 months ago

The Report Settings Template API now supports the ability to create public templates. We need to add support for the isPublic property to this Crowdin API client.

References:

indra057 commented 9 months ago

i am trying to understand what to fix but i am not getting it can u describe it a little bit ..it would be of great help?? and is there any possibility that u can assign me this?

andrii-bodnar commented 9 months ago

@indra057 please refer to similar PRs, for example - https://github.com/crowdin/crowdin-api-client-java/pull/198/

thank you!

indra057 commented 9 months ago

do we need to add isPublic property in this file?? https://github.com/crowdin/crowdin-api-client-java/blob/master/src/main/java/com/crowdin/client/reports/model/ReportSettingsTemplate.java

andrii-bodnar commented 9 months ago

@indra057 yes, but please check the related code as well, we'll probably need to update some other files like in the mentioned pull request

andrii-bodnar commented 9 months ago

@indra057 any updates on this?