search

crowdin / crowdin-api-client-java

Java client library for Crowdin API
https://jitpack.io/#crowdin/crowdin-api-client-java
MIT License
67 stars 44 forks source link

Remove the `markAddedTranslationsAsDone` parameter #229

Closed andrii-bodnar closed 6 months ago

andrii-bodnar commented 7 months ago

this parameter is deprecated in the API and should be removed from the codebase.

imraklr commented 6 months ago

I would like to take up this task.

Do I need to run the unit tests after removing this parameter?

I have not found any usage of parameter markAddedTranslationsAsDone. So it is safe to delete without running unit tests.

andrii-bodnar commented 6 months ago

@imraklr sure, we'd be happy to accept the contribution!

imraklr commented 6 months ago

I've addressed the linting issues and amended the commit message accordingly. The force push was necessary to update the commit history. Please review the changes and let me know if there are any further adjustments needed.