search

crowdin / crowdin-api-client-php

PHP client library for Crowdin API
https://packagist.org/packages/crowdin/crowdin-api-client
MIT License
58 stars 31 forks source link

Fix glossary download method #134

Closed ivdimova closed 1 year ago

ivdimova commented 1 year ago

The glossary download method here https://github.com/crowdin/crowdin-api-client-php/blob/43409bc45b1d4f7c43bd1881c4b42c6cfc530020/src/CrowdinApiClient/Api/GlossaryApi.php#L132 is outdated and doesn't include the exportId as noted in the API documentation.

ivdimova commented 1 year ago

@andrii-bodnar so I've updated the method and the tests, but seems for some reason I can't push a branch to this repo. Can you think of a setting/reason for this? Clone/pull worked just fine.

andrii-bodnar commented 1 year ago

@ivdimova you need to fork the repo and then Creating a pull request from a fork

andrii-bodnar commented 1 year ago

Available in 1.9.4

ivdimova commented 1 year ago

Thank you!