Closed pdelre closed 1 year ago
FYI, most of these failed tests quite minor issues with the test themselves (comparing an array
to a string
containing json). A small number are issues with the Api implementations themselves.
I'll have a PR next week to resolve.
@pdelre nice catch, thanks for pointing that out! We'd be happy to accept a PR :)
The two
AbstractTestApi::mockRequest
implementations have a bug (likely typo) where it will never assert the called body & header as the assertion is testing the same values ($params['body']
vs$params['body']
).https://github.com/crowdin/crowdin-api-client-php/blob/811b26ffa5335671c4b27eb38f8f18891ade8c14/tests/CrowdinApiClient/Api/AbstractTestApi.php#L46-L51 https://github.com/crowdin/crowdin-api-client-php/blob/811b26ffa5335671c4b27eb38f8f18891ade8c14/tests/CrowdinApiClient/Api/Enterprise/AbstractTestApi.php#L47-L52
This is masking 41 failures: