search

crowdin / crowdin-cli

A command-line client for the Crowdin API
https://crowdin.github.io/crowdin-cli
MIT License
250 stars 94 forks source link

fix(aur): set & force java-environment=17 #848

Closed tippfehlr closed 1 month ago

tippfehlr commented 2 months ago

The currently used gradlew version does not support the latest java. To fix this, specify java-environment=17 and put any jdk17 to the front of PATH, in case a jdk17 is not currently selected by the user.

And:

Closes: #847

andrii-bodnar commented 2 months ago

@tippfehlr thanks a lot for the contribution! 🚀

@cmrd-senya could you please review this PR?

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.90%. Comparing base (cb0e8eb) to head (2e4367c). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #848 +/- ## ========================================= Coverage 65.90% 65.90% Complexity 1522 1522 ========================================= Files 225 225 Lines 6210 6210 Branches 940 940 ========================================= Hits 4092 4092 Misses 1576 1576 Partials 542 542 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tippfehlr commented 2 months ago

Ah and I removed the conflicts array because crowdin-cli-bin has a conflict with crowdin-cli and this package conflicts with crowdin-cli automatically

tippfehlr commented 1 month ago

Thanks!