search

crowdin / github-action

A GitHub action to manage and synchronize localization resources with your Crowdin project
https://crowdin.com
MIT License
164 stars 56 forks source link

Export settings issue #247

Open AndrewStoyan opened 2 months ago

AndrewStoyan commented 2 months ago

Is your feature request related to a problem? Please describe.

Export options in the action config are partially ignored. If you specify skip_untranslated_strings, skip_untranslated_files, or export_only_approved as true, they work fine, overriding the project export settings.

However, if you specify them as false, they are ignored and the project settings are used.

Describe the solution you'd like

In my opinion, the expected behavior should also override the export options when they are set to false.

joshuatbrown commented 1 month ago

Oh wow -- I didn't realize this was why the action wasn't working for me. Thanks for reporting this! Hope the issue is addressed!