search

crowdint / gopher-spree-api

2 stars 1 forks source link

Create reliable build/test process via a Makefile #71

Closed joiggama closed 6 years ago

joiggama commented 9 years ago

Build and test processes should be defined in the project, let's use a Makefile for this so we can have an automated/documented and homogenous build process.

jpfuentes2 commented 9 years ago

All non-trivial Go projects should have a Makefile!

jpfuentes2 commented 9 years ago

Also, does anyone on this project have experience with Vagrant? It'd be nice to stand up the Spree store and any other necessary services automatically via vagrant up.

joiggama commented 9 years ago

@jpfuentes2 I proposed it from the start, we might support more than one version, so perhaps we need to setup multiple stores in a vagrant box.

I volunteer, I like vagrant.

jpfuentes2 commented 9 years ago

Yeah, I do a lot of my work in Vagrant, see https://github.com/crowdint/grpc-twitter-example.

If you're going to use it to setup a Spee store, I think it'd be awesome to think higher-level: could we make a general Vagrantfile first so we can standup Spree stores in w/ a simple vagrant up for demo purposes for our clients and then a secondary or extension of this specifically for gopher-spree-api? Basically, can you take a step back from gopher-spree-api and think long-term goals?

joiggama commented 9 years ago

@jpfuentes2 Yes, I'll do it.

jpfuentes2 commented 9 years ago

Awesome, thank you :)