search

crowdint / gopher-spree-api

2 stars 1 forks source link

Populate display_* attributes (money) for API responses #82

Closed joiggama closed 9 years ago

joiggama commented 9 years ago

Compute display_* attributes for the orders endpoints taking into account the related float values and the entity currency.

mumoc commented 9 years ago

Always provide a brief description on what's the PR trying to implement

mumoc commented 9 years ago

Overall, LGTM

joiggama commented 9 years ago

@mumoc thanks, this is still a WIP as stated in the PR title. I've been tracking a bug, there's something weird happening in the products endpoints where the variants are not reading the CostCurrency field from the database, this is necessary to calculate the products display attributes.

In the mean time, we could merge this, and I will open another for the products endpoints once I find the issue.