isay-sosa commented 9 years ago

Still Missing

Product Params

Option Types by option_types key or using options: {name, value} value inside variants key
Product Callbacks
Add associations from prototype
Build variants from option values hash, when option values are present
Touch callbacks if something changed
Variant Callbacks
Set positon for variants that are not master
Master out of stock when IsMaster is false
Stock Item Validations
Uniqueness of VariantId, (StockLocationId, DeletedAt)
Presence of StockLocationId and VariantId
CountOnHand greater than or equal to 0
Stock Item Callbacks
Touch variant when stock item changes

mumoc commented 9 years ago

I'm not sure if the PR includes all items from your comment OR those are the parts missing xD; Please provide a clear description of your PR implementation for future PR

isay-sosa commented 9 years ago

@mumoc no, those are the missing parts

mumoc commented 9 years ago

Overall, LGTM

cone commented 9 years ago

LGTM after rebasing master

crowdint / gopher-spree-api

Feature/post product #85

Still Missing

Product Params

Product Callbacks

Variant Callbacks

Stock Item Validations

Stock Item Callbacks