search

crowdint / rails3-jquery-autocomplete

An easy and unobtrusive way to use jQuery's autocomplete with Rails 3
http://rubygems.org/gems/rails3-jquery-autocomplete
MIT License
917 stars 367 forks source link

Change Autocomplete.autocomplete default of items in 1.0.13 #263

Closed TalkativeTree closed 10 years ago

TalkativeTree commented 10 years ago

in Autocomplete.json_for_autocomplete, collect! is being called on items, which is defaulted to items = {}, however .collect! is not a Hash method, which is causing errors. I suggest changing it to items - []. I haven't this, because the 1.0.13 code hasn't been posted.

TalkativeTree commented 10 years ago

Btw, the Travis CI build failed, because they tests are testing that they're receiving {}, when the change I made sends a []

bigtunacan commented 10 years ago

This is fixed by pull request #264 which is more flexible and build continues to pass.

TalkativeTree commented 10 years ago

:+1: