crowdrec / idomaar

CrowdRec reference framework
Apache License 2.0
32 stars 12 forks source link

Testing phase using HTTP instead of 0MQ doesn't work #74

Closed morellodev closed 8 years ago

morellodev commented 8 years ago

I'm using HTTP as communication protocol between computing environment and orchestrator and I have implemented a HTTP REST server in Python that runs into the computing environment. The problem arises when the testing phase starts: orchestrator is keep waiting for a finish message from recommendation manager (actually the HTTP server itself) and nothing happens until the execution is manually interrupted. Flume's log files contains these exceptions:

andreas-dai commented 8 years ago

Hi Dennis, regarding the problem, I am not the expert. It looks to me as if a component is missing or the java dependencies are not configured correctly. I guess that Davide or Andras are the experts for this problem. Kind Regards, Andreas

morellodev commented 8 years ago

Thanks Andreas, let's wait for a response from Andras.

andras-sereny commented 8 years ago

Hi Dennis, do you have a command line I can run to reproduce the issue?

morellodev commented 8 years ago

You can find all the necessary to reproduce it into the branch neural-network

andras-sereny commented 8 years ago

How do you start Idomaar?

morellodev commented 8 years ago

Give me a sec, I'm pushing my local changes :)

morellodev commented 8 years ago

Ok I have pushed my changes, you can start Idomaar by launching "idomaar-demo.sh" in the root folder

andras-sereny commented 8 years ago

The neural-network branch has some issues atm: gru_recommender.py is missing the web.py dependency and it tries to use the same port 2760 where the old Mahout recommender is listening. If I fix these, there's still some spark-submit error, probably due to the fact that the branch is based on an old Idomaar version.

As for the original issue, the point here is that in case of an HTTP comp env, our interceptor in Flume did not send an finished message to the orchestartor. I have fixed this on the aws branch, which I think is the most up to date, https://github.com/crowdrec/idomaar/commit/c2655933430715c28de619b594fbd18090fd1816 . I cannot reproduce the Flume errors mentioned above, but in any case, their occurrence cannot depend on the TCP/HTTP computing environment choice.

@davidemalagoli , could we merge the aws branch to master? Also, idomaar-demo.sh still fails in the eval phase, see #75. who could take a look at it? Thanks, András

davidemalagoli commented 8 years ago

merged aws into master