Closed Brettdah closed 1 year ago
@Brettdah: Thanks for opening an issue, it is currently awaiting triage.
In the meantime, you can:
Hi @Brettdah
I don't know or remember why the PR was closed, but I planned to fix the issue after landing the functional tests for docker containers in the master branch (directory docker/tests)
I'll have a look and get back to you tomorrow. Thanks!
it seems it was my mistake I'm not used to work with public repos, in the company I was when I submited the PR I was deleting the branch as soon as I pushed sent the PR (partly because I was the one to accept the PR too) so that's why it was claused xD
so yeah, PEBCAK on me^^
as I said the with the cp -n there should not be any problem but if I were you I would build the image with the /etc/crowdsec already filled with what's in the /staging/etc/crowdsec/
the bing directive will put any personal config on top of your default one and take precedence over the default file present in the Image (hope I'm clear enough, english is not my first language)
thanks for your reply ! waiting to read you soon :)
Hi @Brettdah
To make it short, the proper way to achieve what you need is to
/etc/crowdsec/config.yaml.local
containing only the followingcrowdsec_service:
acquisition_dir: /etc/crowdsec/acquisitions
and any other configuration that you many need to change over the default one. This way you don't need to mount config.yaml to the container anymore.
The .local and acquis.d features have been there for over a year, it's just that the docker documentation was not updated to take advantage of them.
Let us know, and thanks again
What happened?
As suggested to the contributing lines I'm openning this issue, I already sent a PR to Fix it but it was closed automaticaly? or without any human comment.
I have found a bug while bind mounting my config.yml on a fresh deployment of crowdsec via docker compose with this compose file :
What did you expect to happen?
the container should start with no errors
How can we reproduce it (as minimally and precisely as possible)?
Just use my compose file and add the acquisition file ssh.yml in the directory I'm using for any of my acquis config, it look messy to have more than 1 config in one file:
Then depending on you docker and especialy docker compose installation:
Anything else we need to know?
when I bind mount the docker-start.sh with this change:
original:
mine
the container start ! why check if the file exists before the copy, with the option -n (--no-cobbler) the existing files will not be replaced... I opened the PR 2035 as suggested by Loz on discord but it was closed... :(
Crowdsec version
OS version
Enabled collections and parsers
Acquisition config
Config show
Prometheus metrics
Related custom configs versions (if applicable) : notification plugins, custom scenarios, parsers etc.