crowdsecurity / crowdsec

CrowdSec - the open-source and participative security solution offering crowdsourced protection against malicious IPs and access to the most advanced real-world CTI.
https://crowdsec.net
MIT License
8.8k stars 453 forks source link

cscli: faster table rendering #3027

Closed mmetc closed 4 months ago

mmetc commented 4 months ago

this should keep exactly the same look as the previous version, except for a missing hyphen when wrapping path names (which should have never been there)

github-actions[bot] commented 4 months ago

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

Details I am a bot created to help the [crowdsecurity](https://github.com/crowdsecurity) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/crowdsecurity/crowdsec/blob/master/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [BirthdayResearch/oss-governance-bot](https://github.com/BirthdayResearch/oss-governance-bot) repository.
github-actions[bot] commented 4 months ago

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

Details I am a bot created to help the [crowdsecurity](https://github.com/crowdsecurity) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/crowdsecurity/crowdsec/blob/master/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [BirthdayResearch/oss-governance-bot](https://github.com/BirthdayResearch/oss-governance-bot) repository.
codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 71.42857% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 52.41%. Comparing base (572b387) to head (3f98eec).

Files Patch % Lines
cmd/crowdsec-cli/prettytable.go 71.13% 25 Missing and 3 partials :warning:
cmd/crowdsec-cli/tables.go 60.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3027 +/- ## ========================================== + Coverage 52.34% 52.41% +0.06% ========================================== Files 276 277 +1 Lines 35140 35180 +40 ========================================== + Hits 18394 18438 +44 Misses 14917 14917 + Partials 1829 1825 -4 ``` | [Flag](https://app.codecov.io/gh/crowdsecurity/crowdsec/pull/3027/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crowdsecurity) | Coverage Δ | | |---|---|---| | [bats](https://app.codecov.io/gh/crowdsecurity/crowdsec/pull/3027/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crowdsecurity) | `40.29% <88.23%> (+0.13%)` | :arrow_up: | | [unit-linux](https://app.codecov.io/gh/crowdsecurity/crowdsec/pull/3027/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crowdsecurity) | `34.82% <0.00%> (-0.04%)` | :arrow_down: | | [unit-windows](https://app.codecov.io/gh/crowdsecurity/crowdsec/pull/3027/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crowdsecurity) | `31.02% <0.00%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crowdsecurity#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.