crowdsecurity / crowdsec

CrowdSec - the open-source and participative security solution offering crowdsourced protection against malicious IPs and access to the most advanced real-world CTI.
https://crowdsec.net
MIT License
8.1k stars 419 forks source link

cscli: log.Fatal -> return err #3049

Closed mmetc closed 3 weeks ago

github-actions[bot] commented 3 weeks ago

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

Details I am a bot created to help the [crowdsecurity](https://github.com/crowdsecurity) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/crowdsecurity/crowdsec/blob/master/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [BirthdayResearch/oss-governance-bot](https://github.com/BirthdayResearch/oss-governance-bot) repository.
github-actions[bot] commented 3 weeks ago

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

Details I am a bot created to help the [crowdsecurity](https://github.com/crowdsecurity) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/crowdsecurity/crowdsec/blob/master/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [BirthdayResearch/oss-governance-bot](https://github.com/BirthdayResearch/oss-governance-bot) repository.
codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 61.11111% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 52.41%. Comparing base (c1e858c) to head (e626ac4).

Files Patch % Lines
cmd/crowdsec-cli/main.go 55.00% 8 Missing and 1 partial :warning:
cmd/crowdsec-cli/decisions_import.go 33.33% 4 Missing :warning:
cmd/crowdsec-cli/alerts_table.go 0.00% 3 Missing :warning:
cmd/crowdsec-cli/flag.go 57.14% 3 Missing :warning:
cmd/crowdsec-cli/notifications.go 0.00% 1 Missing :warning:
cmd/crowdsec-cli/papi.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3049 +/- ## ========================================== - Coverage 58.41% 52.41% -6.00% ========================================== Files 268 280 +12 Lines 27753 35478 +7725 ========================================== + Hits 16212 18596 +2384 - Misses 9749 15040 +5291 - Partials 1792 1842 +50 ``` | [Flag](https://app.codecov.io/gh/crowdsecurity/crowdsec/pull/3049/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crowdsecurity) | Coverage Δ | | |---|---|---| | [bats](https://app.codecov.io/gh/crowdsecurity/crowdsec/pull/3049/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crowdsecurity) | `40.14% <70.21%> (-0.04%)` | :arrow_down: | | [unit-linux](https://app.codecov.io/gh/crowdsecurity/crowdsec/pull/3049/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crowdsecurity) | `34.78% <0.00%> (-0.02%)` | :arrow_down: | | [unit-windows](https://app.codecov.io/gh/crowdsecurity/crowdsec/pull/3049/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crowdsecurity) | `30.94% <0.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crowdsecurity#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.