crowdsecurity / crowdsec

CrowdSec - the open-source and participative security solution offering crowdsourced protection against malicious IPs and access to the most advanced real-world CTI.
https://crowdsec.net
MIT License
8.1k stars 419 forks source link

lint: enable revive/if-return, revive/error-strings #3057

Closed mmetc closed 3 weeks ago

github-actions[bot] commented 3 weeks ago

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

Details I am a bot created to help the [crowdsecurity](https://github.com/crowdsecurity) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/crowdsecurity/crowdsec/blob/master/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [BirthdayResearch/oss-governance-bot](https://github.com/BirthdayResearch/oss-governance-bot) repository.
codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 70.83333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 52.41%. Comparing base (3dd17b9) to head (1aac53a).

Files Patch % Lines
pkg/parser/node.go 50.00% 3 Missing :warning:
cmd/crowdsec-cli/lapi.go 0.00% 2 Missing :warning:
cmd/crowdsec-cli/papi.go 0.00% 1 Missing :warning:
pkg/exprhelpers/helpers.go 85.71% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3057 +/- ## =========================================== + Coverage 34.05% 52.41% +18.35% =========================================== Files 279 280 +1 Lines 35491 35460 -31 =========================================== + Hits 12088 18586 +6498 + Misses 22093 15042 -7051 - Partials 1310 1832 +522 ``` | [Flag](https://app.codecov.io/gh/crowdsecurity/crowdsec/pull/3057/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crowdsecurity) | Coverage Δ | | |---|---|---| | [bats](https://app.codecov.io/gh/crowdsecurity/crowdsec/pull/3057/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crowdsecurity) | `40.17% <64.28%> (?)` | | | [unit-linux](https://app.codecov.io/gh/crowdsecurity/crowdsec/pull/3057/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crowdsecurity) | `34.83% <28.57%> (+0.02%)` | :arrow_up: | | [unit-windows](https://app.codecov.io/gh/crowdsecurity/crowdsec/pull/3057/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crowdsecurity) | `30.93% <41.66%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crowdsecurity#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.