crowdsecurity / crowdsec

CrowdSec - the open-source and participative security solution offering crowdsourced protection against malicious IPs and access to the most advanced real-world CTI.
https://crowdsec.net
MIT License
8.1k stars 419 forks source link

cscli: refactor "cscli setup" to avoid global variable #3075

Closed mmetc closed 2 weeks ago

github-actions[bot] commented 2 weeks ago

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

Details I am a bot created to help the [crowdsecurity](https://github.com/crowdsecurity) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/crowdsecurity/crowdsec/blob/master/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [BirthdayResearch/oss-governance-bot](https://github.com/BirthdayResearch/oss-governance-bot) repository.
github-actions[bot] commented 2 weeks ago

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

Details I am a bot created to help the [crowdsecurity](https://github.com/crowdsecurity) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/crowdsecurity/crowdsec/blob/master/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [BirthdayResearch/oss-governance-bot](https://github.com/BirthdayResearch/oss-governance-bot) repository.
codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 71.15385% with 30 lines in your changes missing coverage. Please review.

Project coverage is 52.55%. Comparing base (bd4540b) to head (b3910ce).

Files Patch % Lines
pkg/setup/install.go 46.34% 22 Missing :warning:
cmd/crowdsec-cli/setup.go 87.30% 7 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3075 +/- ## ========================================== + Coverage 52.49% 52.55% +0.06% ========================================== Files 281 281 Lines 35435 35383 -52 ========================================== - Hits 18602 18596 -6 + Misses 15011 14974 -37 + Partials 1822 1813 -9 ``` | [Flag](https://app.codecov.io/gh/crowdsecurity/crowdsec/pull/3075/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crowdsecurity) | Coverage Δ | | |---|---|---| | [bats](https://app.codecov.io/gh/crowdsecurity/crowdsec/pull/3075/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crowdsecurity) | `40.26% <78.72%> (-0.01%)` | :arrow_down: | | [unit-linux](https://app.codecov.io/gh/crowdsecurity/crowdsec/pull/3075/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crowdsecurity) | `34.86% <0.00%> (+0.03%)` | :arrow_up: | | [unit-windows](https://app.codecov.io/gh/crowdsecurity/crowdsec/pull/3075/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crowdsecurity) | `31.01% <0.00%> (+0.06%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crowdsecurity#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.