search

crowdsecurity / crowdsec

CrowdSec - the open-source and participative security solution offering crowdsourced protection against malicious IPs and access to the most advanced real-world CTI.
https://crowdsec.net
MIT License
8.1k stars 419 forks source link

cscli: fixed some inconsistency in returning errors #3076

Closed mmetc closed 2 weeks ago

mmetc commented 2 weeks ago

note: cmd.Help() never fails if it's not customized with HelpFunc()

github-actions[bot] commented 2 weeks ago

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

Details I am a bot created to help the [crowdsecurity](https://github.com/crowdsecurity) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/crowdsecurity/crowdsec/blob/master/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [BirthdayResearch/oss-governance-bot](https://github.com/BirthdayResearch/oss-governance-bot) repository.
codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 52.49%. Comparing base (bd4540b) to head (1c8bf5b).

Files Patch % Lines
cmd/crowdsec-cli/hubtest.go 0.00% 4 Missing :warning:
cmd/crowdsec-cli/lapi.go 0.00% 2 Missing :warning:
cmd/crowdsec-cli/simulation.go 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3076 +/- ## ======================================= Coverage 52.49% 52.49% ======================================= Files 281 281 Lines 35435 35427 -8 ======================================= - Hits 18602 18599 -3 + Misses 15011 15005 -6 - Partials 1822 1823 +1 ``` | [Flag](https://app.codecov.io/gh/crowdsecurity/crowdsec/pull/3076/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crowdsecurity) | Coverage Δ | | |---|---|---| | [bats](https://app.codecov.io/gh/crowdsecurity/crowdsec/pull/3076/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crowdsecurity) | `40.27% <11.11%> (-0.01%)` | :arrow_down: | | [unit-linux](https://app.codecov.io/gh/crowdsecurity/crowdsec/pull/3076/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crowdsecurity) | `34.81% <0.00%> (-0.02%)` | :arrow_down: | | [unit-windows](https://app.codecov.io/gh/crowdsecurity/crowdsec/pull/3076/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crowdsecurity) | `30.95% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crowdsecurity#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.