crowdsecurity / crowdsec

CrowdSec - the open-source and participative security solution offering crowdsourced protection against malicious IPs and access to the most advanced real-world CTI.
https://crowdsec.net
MIT License
9.08k stars 470 forks source link

loki: add no_ready_check option #3317

Closed blotus closed 2 weeks ago

blotus commented 2 weeks ago

When using Loki hosted in Grafana cloud, the /ready endpoint does not exist, which prevents crowdsec from starting.

Add an option to bypass this check. Defaults to false to keep the same behavior by default.

github-actions[bot] commented 2 weeks ago

@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

Details I am a bot created to help the [crowdsecurity](https://github.com/crowdsecurity) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/crowdsecurity/crowdsec/blob/master/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [BirthdayResearch/oss-governance-bot](https://github.com/BirthdayResearch/oss-governance-bot) repository.
github-actions[bot] commented 2 weeks ago

@blotus: There are no area labels on this PR. You can add as many areas as you see fit.

Details I am a bot created to help the [crowdsecurity](https://github.com/crowdsecurity) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/crowdsecurity/crowdsec/blob/master/.github/governance.yml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the [BirthdayResearch/oss-governance-bot](https://github.com/BirthdayResearch/oss-governance-bot) repository.
blotus commented 2 weeks ago

/kind enhancement /area agent

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 73.07692% with 7 lines in your changes missing coverage. Please review.

Project coverage is 58.46%. Comparing base (19b70f1) to head (437223d). Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/acquisition/modules/loki/loki.go 73.07% 5 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3317 +/- ## ======================================= Coverage 58.45% 58.46% ======================================= Files 351 351 Lines 37626 37631 +5 ======================================= + Hits 21996 22000 +4 - Misses 13732 13733 +1 Partials 1898 1898 ``` | [Flag](https://app.codecov.io/gh/crowdsecurity/crowdsec/pull/3317/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crowdsecurity) | Coverage Δ | | |---|---|---| | [bats](https://app.codecov.io/gh/crowdsecurity/crowdsec/pull/3317/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crowdsecurity) | `41.25% <0.00%> (-0.01%)` | :arrow_down: | | [unit-linux](https://app.codecov.io/gh/crowdsecurity/crowdsec/pull/3317/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crowdsecurity) | `34.40% <73.07%> (-0.01%)` | :arrow_down: | | [unit-windows](https://app.codecov.io/gh/crowdsecurity/crowdsec/pull/3317/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crowdsecurity) | `29.65% <11.53%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=crowdsecurity#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.