search

crowdsecurity / helm-charts

CrowdSec community kubernetes helm charts
MIT License
27 stars 33 forks source link

fix(lapi): lapi should have unique internal machine for cscli #186

Closed he2ss closed 2 months ago

he2ss commented 2 months ago

fix #181

This allows the lapi deployment to generate unique machine names in the database :

example result:

────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
 Name                                              IP Address   Last Update           Status  Version                 Auth Type  Last Heartbeat 
────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
 crowdsec-lapi-6f5444d89-l8s8l                                  2024-08-27T12:22:47Z  ✔️                              password   1m31s          
 vG1i0fbcsRdpgCwatzYCFSVnFkOHoBUsVu1zC58ULWv2rLFk  10.244.0.10  2024-08-27T12:24:06Z  ✔️      v1.6.2-16bfab86-docker  password   12s            
 crowdsec-lapi-6f5444d89-r96n8                                  2024-08-27T12:22:48Z  ✔️                              password   1m30s          
────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
github-actions[bot] commented 2 months ago

@he2ss: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

Details I am a bot created to help the [crowdsecurity](https://github.com/crowdsecurity) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/crowdsecurity/helm-charts/blob/main/.github/governance.yaml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the forked project [rr404/oss-governance-bot](https://github.com/rr404/oss-governance-bot) repository.
github-actions[bot] commented 2 months ago

@he2ss: There are no area labels on this PR. You can add as many areas as you see fit.

Details I am a bot created to help the [crowdsecurity](https://github.com/crowdsecurity) developers manage community feedback and contributions. You can check out my [manifest file](https://github.com/crowdsecurity/helm-charts/blob/main/.github/governance.yaml) to understand my behavior and what I can do. If you want to use this for your project, you can check out the forked project [rr404/oss-governance-bot](https://github.com/rr404/oss-governance-bot) repository.
he2ss commented 2 months ago

/area local-api /kind fix

LaurenceJJones commented 2 months ago

q: would it be best to auto set the custom hostname for agents too as then when looking cscli machines list you can see the lp name that you expect to be inside cluster?

he2ss commented 2 months ago

This change for agents involves some important changes in the TLS feature also and little bit more complicated than the one for lapi. I suggest we don't do this in this PR.