Get rid of obsolete/unused build dependencies

CyrilBrulebois commented 2 years ago

At least ent and grokky were moved to different packages, it makes sense to remove them from build dependencies and from dependencies so that those packages can get removed eventually.

Maybe some automated tool exists to iterate on all build dependencies to see which ones could be spared?

CyrilBrulebois commented 2 years ago

That looks promising, even if some packages might be false positives due to naming convention (vN packages, etc.):

$ dh-make-golang check-depends
[…]
RM dependency  (golang-github-aquasecurity-table-dev)
RM dependency  (golang-github-blackfireio-osinfo-dev)
RM dependency  (golang-github-facebook-ent-dev)
RM dependency  (golang-github-ivanpirog-coloredcobra-dev)
RM dependency  (golang-github-jackc-pgx-v4-dev)
RM dependency  (golang-github-logrusorgru-grokky-dev)
RM dependency  (golang-github-olekukonko-tablewriter-dev)
RM dependency  (golang-github-opencontainers-image-spec-dev)
RM dependency  (golang-github-r3labs-diff-dev)
RM dependency  (golang-github-slack-go-slack-dev)
RM dependency  (golang-github-texttheater-golang-levenshtein-dev)
RM dependency  (golang-github-xhit-go-simple-mail-dev)
RM dependency  (golang-gopkg-jarcoal-httpmock.v1-dev)

CyrilBrulebois commented 1 year ago

Relevant commits:

$ git log a9a49b1cb1cf1a8373397783640c4b22ec2c5979..497ace686aaed5e4a04c37c1d705b9f1f35aaa1b
commit 497ace686aaed5e4a04c37c1d705b9f1f35aaa1b
Author: Cyril Brulebois <cyril@debamax.com>
Date:   Thu Nov 24 06:09:31 2022 +0000

    Replace golang-yaml.v2-dev with golang-gopkg-yaml.v2-dev

commit 7d6bf63a0a38bdd711003ec4bae2838ea7d2c01d
Author: Cyril Brulebois <cyril@debamax.com>
Date:   Thu Nov 24 06:08:42 2022 +0000

    Replace golang-prometheus-client-dev with golang-github-prometheus-client-golang-dev

commit f4a68711a886935691660ce6d4890d21fccfcdad
Author: Cyril Brulebois <cyril@debamax.com>
Date:   Thu Nov 24 06:07:39 2022 +0000

    Replace golang-pq-dev with golang-github-lib-pq-dev

commit c7a2bb5dd582fbc8ed39d072fd3b102a4556a44d
Author: Cyril Brulebois <cyril@debamax.com>
Date:   Thu Nov 24 06:05:36 2022 +0000

    Replace golang-logrus-dev with golang-github-sirupsen-logrus-dev

commit ec7db8ef1d93610c94a1bf26509da32f0c54b2c3
Author: Cyril Brulebois <cyril@debamax.com>
Date:   Thu Nov 24 07:02:32 2022 +0100

    Delete golang-gopkg-jarcoal-httpmock.v1-dev

    Since upstream's git history has no references to that one, it seems
    like an erroneous addition during the 1.4.x preparations (with both
    golang-github-jarcoal-httpmock-dev – the correct one – and
    golang-gopkg-jarcoal-httpmock.v1-dev – the incorrect one – getting
    added).

commit 229cf341198a90c5497391d9cac104581465d317
Author: Cyril Brulebois <cyril@debamax.com>
Date:   Thu Nov 24 06:59:08 2022 +0100

    Delete golang-github-olekukonko-tablewriter-dev (no longer used)

commit 9c93523c1f974a89935cbaec6284587842bd48d4
Author: Cyril Brulebois <cyril@debamax.com>
Date:   Thu Nov 24 06:58:08 2022 +0100

    Delete golang-github-logrusorgru-grokky-dev (replaced with golang-github-crowdsecurity-grokky-dev)

commit 44f2a75e122b22cbe34fd8b556b9ac98da7b6ced
Author: Cyril Brulebois <cyril@debamax.com>
Date:   Thu Nov 24 06:56:05 2022 +0100

    Delete golang-github-facebook-ent-dev (replaced with golang-entgo-ent-dev).

crowdsecurity / packaging-debian

Get rid of obsolete/unused build dependencies #4