search

crowdsecurity / pfSense-pkg-crowdsec

58 stars 2 forks source link

"standard" tables #67

Open mmetc opened 1 year ago

mmetc commented 1 year ago

This is not a priority and can be done after the first release, but the current datatables look out of place in the pfsense UI.

Would it be feasible to use the same tables as "Status -> DHCP Leases", "Status -> Gateways" etc? Would it require converting the current JS data manip to PHP?

julienloizelet commented 1 year ago

I am not sure to understand.

"Status -> DHCP Leases" and "Status -> Gateways" are done with some PHP/html files in the pfsense source code: usr/local/www/status_gateways.php and usr/local/www/status_dhcp_leases.php. We can not use it.

Here is a screenshot of the Status->Gateways page. Capture d’écran du 2023-10-13 15-11-15

and here is one of the Crowdsec pages (Metrics one): Capture d’écran du 2023-10-13 15-15-06

If you are talking about the tabs design (Gateways and Gateways group VS acquisition, bucket, parser, (etc.) tabs ), the main difference is that gateway tabs point to different urls : status_gateways.php and status_gateway_groups.php whereas our tabs are on the same page and updated with some ajax request.

When we point to different url, we have the same design :

Capture d’écran du 2023-10-13 15-19-50

I guess we could do some css to make the CrowdSec "ajax tabs" looks like pfSense "url link tabs". Is that what you want ?