crowell / modpagespeed_tmp

Automatically exported from code.google.com/p/modpagespeed
Apache License 2.0
0 stars 0 forks source link

pagespeed_no_defer and pagespeed_lsc_url break HTML5 validation #584

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
mod_pagespeed alters script and css tags to have the above tags, which break 
HTML5 validation (see 
http://validator.w3.org/check?uri=https://workbenchwarriors.com/&charset=%28dete
ct+automatically%29&doctype=HTML5&group=0 for an example).

These attributes would be better added as data-pagespeed-no-defer and 
data-pagespeed-lsc-url respectively, to pass HTML5 validation (see described 
here: http://html5doctor.com/html5-custom-data-attributes/) 

Original issue reported on code.google.com by bar...@shrikeh.net on 7 Dec 2012 at 11:57

GoogleCodeExporter commented 9 years ago
To clarify, pagespeed-no-defer is something that mod_pagespeed allows you to 
specify on your tags, which mod_pagespeed then interprets.

mod_pagespeed should allow those to be specified in an HTML5-complaint way, 
such as the syntax you provide.

Additionally, the 'pedantic' filter could modify in-place markup specifying the 
non-html5-compliant syntax.

Original comment by jmara...@google.com on 7 Dec 2012 at 6:09

GoogleCodeExporter commented 9 years ago
Yep, that's what I was trying to say - badly. Thanks for clarifying. The tags 
in questions are added by the local_storage_cache filter in my example.

Original comment by bar...@shrikeh.net on 10 Dec 2012 at 5:21